-
Notifications
You must be signed in to change notification settings - Fork 26
docs/alerts: explain how alerts work and their issues #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| ## How do Utilization Alerts work? | ||
|
|
||
| Utilization alerts work in a way that surprises some users, typically wondering | ||
| why a specific utilization alert has not been notified. Here is a description of | ||
| how they work so that users can understand why that is the case. | ||
|
|
||
| ### Utilization percentages | ||
|
|
||
| Apisonator will emit alerts to the administrative instance for traffic crossing | ||
| the following utilization percentage of an application _if configured to do so_: | ||
|
|
||
| 0, 50, 80, 90, 100, 120, 150, 200, 300 | ||
|
|
||
| However, only one alert percentage is to be notified in any given 24h period. | ||
|
|
||
| ### Alert notification | ||
|
|
||
| Alerts are only sent **once** in any given 24 hours period for each application and | ||
| utilization percentage regardless of the period for which the utilization | ||
| percentage was computed. | ||
|
|
||
| This means that once a configured alert is emitted for a particular application, | ||
| such as 120% utilization for any period (ie. minute), no alert will be emitted | ||
| for that particular application and utilization level for the next 24 hours, | ||
| even if the utilization that would reach 120% would be applying to a different | ||
| period (ie. hour), or even if the alert would be emitted for a different metric. | ||
|
|
||
| If, however, the utilization percentage would have not been notified in the | ||
| previous 24 hours, such as 150, then it is notified. | ||
|
|
||
| ### Issues | ||
|
|
||
| This behaviour is surprising to users because they might expect an alert | ||
| notified the last day to be "forgotten" by the next day even though 24h have not | ||
| really elapsed. | ||
|
|
||
| There is also the additional issue that alerts that could not be sent are stored | ||
| for sending later on, but the code requires another actual alert to be generated | ||
| in order for those pending alerts to be sent. This is usually not a big deal but | ||
| still has potential for edge cases to behave very weirdly. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also mention metrics.
When an alert has been sent for a given app and utilization %, it won't be sent again when going over limits for a different metric.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidor does the change in the commit below make it all read ok to you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍