Makefile: remove ruby from building steps#61
Conversation
|
|
||
| .PHONY: ci-build | ||
| ci-build: export APISONATOR_REL?=v$(shell ruby -r$(PROJECT_PATH)/lib/3scale/backend/version -e "puts ThreeScale::Backend::VERSION") | ||
| ci-build: export APISONATOR_REL?=v$(shell docker run --rm -e RBENV_VERSION='2.3.6' -v $(PROJECT_PATH):/tmp/apisonator:z \ |
There was a problem hiding this comment.
can we remove the RBENV_VERSION there? If not, perhaps we can just specify 2.3 or even 2 - otherwise we will be depending on the CI image always having a 2.3.6 release.
There was a problem hiding this comment.
Is there any way to disable rbenv or use default version? Otherwise, using another image could work, like centos/ruby-23-centos7
There was a problem hiding this comment.
It should be ready to read the .ruby-version in the app root and use that to get the version (ie. do not define the env variable and first cd into the directory before running ruby).
There was a problem hiding this comment.
also, using a different image would work but would not be practical as another image would need to be download just for this and you would still encode the version here instead of using the app/ci image version
There was a problem hiding this comment.
used .ruby-version of the project 👍
eguzki
force-pushed
the
makefile-not-using-ruby
branch
from
192f04a to
39ba207
Compare
unleashed
left a comment
unleashed
left a comment
There was a problem hiding this comment.
LGTM - it appears CircleCI broke?
eguzki
force-pushed
the
makefile-not-using-ruby
branch
from
39ba207 to
09fc9b6
Compare
|
bors r=@unleashed |
Timed out |
2 participants
Remove requirement from the building environment to have ruby installed. Docker will be the only tool required to build the project.