Skip to content

Dockerfile.ci: rubygems-update fix to 2.7.8#68

Merged
eguzki merged 1 commit intomasterfrom
fix/rubygems-update-require-ruby-2.3
Jan 22, 2019
Merged

Dockerfile.ci: rubygems-update fix to 2.7.8#68
eguzki merged 1 commit intomasterfrom
fix/rubygems-update-require-ruby-2.3

Conversation

@eguzki
Copy link
Copy Markdown
Member

@eguzki eguzki commented Jan 22, 2019

Fix rubygems-update to 2.7.8

rubygems-update ~> 3.0 requires ruby >= 2.3. Breaks our tests for ruby 2.2

Step 53/63 : RUN sudo chown -R "${USER_NAME}": /tmp/apisonator     && cd /tmp/apisonator     && rbenv_update_env

 ---> Running in 8586b5cf70e6


Downloading ruby-2.2.4.tar.bz2...

-> https://cache.ruby-lang.org/pub/ruby/2.2/ruby-2.2.4.tar.bz2

Installing ruby-2.2.4...


WARNING: ruby-2.2.4 is nearing its end of life.

It only receives critical security updates, no bug fixes.

Installed ruby-2.2.4 to /home/ruby/.rbenv/versions/2.2.4


ERROR:  Error installing rubygems-update:

    rubygems-update requires Ruby version >= 2.3.0.

ERROR:  While executing gem ... (NoMethodError)

    undefined method `version' for nil:NilClass

Updating rubygems-update

The command '/bin/sh -c sudo chown -R "${USER_NAME}": /tmp/apisonator     && cd /tmp/apisonator     && rbenv_update_env' returned a non-zero code: 1

@eguzki eguzki requested a review from davidor January 22, 2019 15:19
@eguzki
Copy link
Copy Markdown
Member Author

eguzki commented Jan 22, 2019

credits to @davidor 🎖️

Copy link
Copy Markdown
Contributor

@unleashed unleashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can still do < 3.0.0?

@davidor
Copy link
Copy Markdown
Contributor

davidor commented Jan 22, 2019

Looks like it's not possible to specify the version like that.

Copy link
Copy Markdown
Contributor

@unleashed unleashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, just make sure you remove this when upgrading Ruby to 2.3+.

@eguzki eguzki merged commit baa78ae into master Jan 22, 2019
@bors bors Bot deleted the fix/rubygems-update-require-ruby-2.3 branch January 22, 2019 22:33
@eguzki
Copy link
Copy Markdown
Member Author

eguzki commented Jan 22, 2019

ups, forgot about our bors friend :'(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants