Feature/delete service stats endpoint#72
Merged
eguzki merged 10 commits intofeature/delete-service-stats-integrationfrom Feb 22, 2019
Merged
Feature/delete service stats endpoint#72eguzki merged 10 commits intofeature/delete-service-stats-integrationfrom
eguzki merged 10 commits intofeature/delete-service-stats-integrationfrom
Conversation
3 tasks
mikz
reviewed
Feb 6, 2019
Member
Author
|
ping @unleashed @davidor |
davidor
reviewed
Feb 15, 2019
davidor
reviewed
Feb 15, 2019
davidor
reviewed
Feb 15, 2019
davidor
reviewed
Feb 15, 2019
davidor
reviewed
Feb 15, 2019
davidor
reviewed
Feb 15, 2019
davidor
reviewed
Feb 15, 2019
davidor
reviewed
Feb 15, 2019
eguzki
force-pushed
the
feature/delete-service-stats-endpoint
branch
from
e2d5e2f to
9516ec3
Compare
Member
Author
|
all coments resolved. Ready for a new review @davidor |
davidor
reviewed
Feb 22, 2019
davidor
reviewed
Feb 22, 2019
Contributor
|
@eguzki , I added a couple of comments. The rest looks good to me. |
davidor
reviewed
Feb 26, 2019
|
|
||
| private | ||
|
|
||
| def validate |
Contributor
There was a problem hiding this comment.
I forgot to mention that we should probably put some kind of limit on the to parameter or on the time interval between to and from. Otherwise, someone could send a call to delete all the keys from 1970 up until now or something like that. We can fix this in the integration branch later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New endpoint to delete stats in internal API
Request body
{ "deletejobdef": { "applications": ["1"], "metrics": ["5"], "from": 1483228800, "to": 1483228800, "users": ["1"] } }