Skip to content

Fix/response code processing#82

Merged
bors[bot] merged 4 commits intomasterfrom
fix/response-code-processing
Mar 5, 2019
Merged

Fix/response code processing#82
bors[bot] merged 4 commits intomasterfrom
fix/response-code-processing

Conversation

@eguzki
Copy link
Copy Markdown
Member

@eguzki eguzki commented Mar 4, 2019

  • Fix Feature/delete service stats #78 (comment)
    Do not raise an exception when a user reports a response code that Apisonator does not track, for example, 304.

  • Do not account for untracked http response codes, currently, for example 304

Comment thread lib/3scale/backend/stats/codes_commons.rb Outdated
@eguzki eguzki force-pushed the fix/response-code-processing branch from 15b4fef to aa12513 Compare March 4, 2019 17:16
@eguzki eguzki requested a review from davidor March 4, 2019 17:17
@eguzki eguzki force-pushed the fix/response-code-processing branch from aa12513 to f79eef2 Compare March 4, 2019 17:39
Comment thread lib/3scale/backend/stats/codes_commons.rb Outdated
@eguzki eguzki force-pushed the fix/response-code-processing branch from f79eef2 to 8dfe36b Compare March 5, 2019 10:57
@davidor
Copy link
Copy Markdown
Contributor

davidor commented Mar 5, 2019

bors r+

bors Bot added a commit that referenced this pull request Mar 5, 2019
82: Fix/response code processing r=davidor a=eguzki

* Fix #78 (comment)
Do not raise an exception when a user reports a response code that Apisonator does not track, for example, 304.

* Do not account for untracked http response codes, currently, for example 304

Co-authored-by: Eguzki Astiz Lezaun <eastizle@redhat.com>
@bors
Copy link
Copy Markdown
Contributor

bors Bot commented Mar 5, 2019

Build succeeded

@bors bors Bot merged commit 8dfe36b into master Mar 5, 2019
@bors bors Bot deleted the fix/response-code-processing branch March 5, 2019 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants