Skip to content

Delete unused Service attrs related with end-users functionality#30

Merged
davidor merged 1 commit intomasterfrom
delete-unused-attrs-service
Apr 9, 2021
Merged

Delete unused Service attrs related with end-users functionality#30
davidor merged 1 commit intomasterfrom
delete-unused-attrs-service

Conversation

@davidor
Copy link
Copy Markdown
Contributor

@davidor davidor commented Apr 8, 2021

The end-users functionality was removed some time ago, so these attributes can be safely deleted.
Related 3scale/apisonator#277

The end-users functionality was removed some time ago, so these attrs
are no longer needed.
@davidor davidor requested a review from unleashed April 8, 2021 15:07
Copy link
Copy Markdown
Contributor

@unleashed unleashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Copy Markdown
Contributor

bors Bot commented Apr 9, 2021

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@davidor
Copy link
Copy Markdown
Contributor Author

davidor commented Apr 9, 2021

bors retry

@bors
Copy link
Copy Markdown
Contributor

bors Bot commented Apr 9, 2021

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@davidor davidor merged commit b777cff into master Apr 9, 2021
@bors bors Bot deleted the delete-unused-attrs-service branch April 9, 2021 08:20
@bors
Copy link
Copy Markdown
Contributor

bors Bot commented Apr 9, 2021

Stopped waiting for PR status (Github check) without running due to duplicate requests to run. You may check Bors to see that this PR is included in a batch by one of the other requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants