Fixes update buttons in new Policies page #1276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martouta
previously approved these changes
Oct 1, 2019
josemigallas
changed the title
damianpm
previously approved these changes
Oct 1, 2019
didierofrivia
previously approved these changes
Oct 1, 2019
josemigallas
dismissed stale reviews from didierofrivia, damianpm, and Martouta
via
338d4d1
josemigallas
force-pushed
the
fix/policies_update_button
branch
from
f8fd10a to
338d4d1
Compare
josemigallas
changed the title
Martouta
reviewed
Oct 1, 2019
josemigallas
force-pushed
the
fix/policies_update_button
branch
from
338d4d1 to
1eec23e
Compare
Martouta
approved these changes
Oct 1, 2019
Contributor
Martouta
left a comment
Martouta
left a comment
There was a problem hiding this comment.
LGTM 👍 @thomasmaas should review too 😄
damianpm
approved these changes
Oct 1, 2019
thomasmaas
approved these changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes broken logic regarding update buttons in Policies:
input#idto simply the id.Verification steps