Merged
Conversation
josemigallas
changed the title
Contributor
Author
|
UPDATE: Our server gets thousands of requests from IE browsers each month. Versions goes from 6 to 11... and there are also requests made from Windows Phones. IMO most of these requests must be done by some automated tests in case some customer is affected we stopped supporting IE11 since 2020 so we should not worry. |
thomasmaas
previously approved these changes
Aug 29, 2022
lvillen
previously approved these changes
Aug 29, 2022
josemigallas
changed the title
lvillen
reviewed
Aug 30, 2022
lib/developer_portal/app/views/developer_portal/javascripts/3scale_v2.js
Outdated
Show resolved
Hide resolved
akostadinov
reviewed
Aug 30, 2022
vendor/active-docs/app/assets/javascripts/active-docs/form_handler.js.erb
Outdated
Show resolved
Hide resolved
mayorova
reviewed
Aug 30, 2022
mayorova
reviewed
Aug 30, 2022
lvillen
previously approved these changes
Aug 31, 2022
nidhi-soni1104
previously approved these changes
Sep 1, 2022
josemigallas
dismissed stale reviews from nidhi-soni1104 and lvillen
via
d7bb815
josemigallas
force-pushed
the
clean_up_ie11
branch
from
0147ca8 to
d7bb815
Compare
lvillen
previously approved these changes
Sep 19, 2022
akostadinov
previously approved these changes
Sep 19, 2022
Contributor
akostadinov
left a comment
akostadinov
left a comment
There was a problem hiding this comment.
For what it's worth, looks good to me. But don't rely on my review on UI.
josemigallas
dismissed stale reviews from akostadinov and lvillen
via
c69ea86
josemigallas
force-pushed
the
clean_up_ie11
branch
from
d7bb815 to
c69ea86
Compare
…ed as of June 2022
josemigallas
force-pushed
the
clean_up_ie11
branch
from
c69ea86 to
c9b32e3
Compare
Contributor
Author
|
Force pushed because the commits were not signed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internet explorer is no longer maintained/supported by Microsoft. 3scale has never officially supported however there are some hacks here and there to make it work. This is a technical debt that degrades our codebase and we should clean it up.
THREESCALE-8613: Clean up IE11 code
Our server still gets requests from IE and Windows Phone browsers but most must should come from automated test. If any customer still uses IE we announced end of support in 2020.