THREESCALE-12325: Disable tenant signup#4242
Conversation
jlledom
changed the title
| end | ||
|
|
||
| test 'returns not found when signup is disabled' do | ||
| Account.any_instance.unstub(:signup_provider_possible?) |
There was a problem hiding this comment.
Nope AFAIK, but Claude was extra careful I guess
jlledom
force-pushed
the
THREESCALE-12325-remove-tenant-signup
branch
from
044c4d8 to
c8851b1
Compare
mayorova
left a comment
mayorova
left a comment
There was a problem hiding this comment.
It's nice that it's a simple and effective change, however it has a side-effect, that I think is undesired.
With this approach, the "Tenant Create" endpoint in the Master API stops working too - and it is not desirable.
So, we need to somehow only check this new setting in the #ensure_signup_possible in the signups controller, but not in #ensure_master_with_plans in Master::Api::ProvidersController.
Also, in the former - maybe adjust the error that is reported from Provider signup not enabled. Check all master\'s plans are in place. to something more generic (because it might be disabled explicitly, not because of the plans)
Right! I fixed it: f1d8073
Also updated in that commit. I updated the test suite accordingly as well. |
|
|
||
| def setup | ||
| host! master_account.external_domain | ||
| Account.any_instance.stubs(:signup_provider_possible?).returns(true) |
There was a problem hiding this comment.
Dead code, the stb does nothing
|
It would be nice to upgrade the PR description, to avoid confusion in future. |
Done. |
Disabled by default Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
jlledom
force-pushed
the
THREESCALE-12325-remove-tenant-signup
branch
from
e279304 to
7dbcf84
Compare
3 participants
What this PR does / why we need it:
This adds a new setting
provider_signup_form_enabledand the env variablePROVIDER_SIGNUP_FORM_ENABLEDto enable tenants signup form from master portal. It's set tofalseby default.Which issue(s) this PR fixes
https://issues.redhat.com/browse/THREESCALE-12325
Verification steps
/p/signup. You should see "Provider signup not enabled."PROVIDER_SIGNUP_ENABLEDto1and restart/p/signup. You should see the signup form