Merged
Conversation
mayorova
force-pushed
the
remove-obsolete-controllers
branch
from
cd26115 to
3692785
Compare
jlledom
previously approved these changes
Apr 17, 2026
Contributor
jlledom
left a comment
jlledom
left a comment
There was a problem hiding this comment.
I'm always in favor of cleanups.
mayorova
force-pushed
the
remove-obsolete-controllers
branch
from
3692785 to
1a26294
Compare
akostadinov
approved these changes
Apr 17, 2026
Contributor
akostadinov
left a comment
akostadinov
left a comment
There was a problem hiding this comment.
Removing code is always good. Approving as long as tests pass.
Contributor
|
btw remember #4094 ? :) |
Contributor
Author
Yes, of course, we need to recover it, I guess 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Removes obsolete controllers that are not used anywhere.
Which issue(s) this PR fixes
TBD
Verification steps
Leap of faith, really, as there are no tests for many of these controllers.
final decommission date: January 18th, 2022as per 3scale SaaS Release Notes.Removal of these controllers is a subset of 💀🔥 Remove forum (Part 3: code and DB) #4094
They were flagged in the Strong Parameters PR: #4248 (comment)
but it doesn't make sense to fix dead code there.
Special notes for your reviewer: