Skip to content

THREESCALE-11393: Upgrade the Dockefile for system image based on RHEL8#1

Merged
mayorova merged 1 commit intomainfrom
upgrade-to-2.15
Nov 18, 2024
Merged

THREESCALE-11393: Upgrade the Dockefile for system image based on RHEL8#1
mayorova merged 1 commit intomainfrom
upgrade-to-2.15

Conversation

@mayorova
Copy link
Copy Markdown
Collaborator

@mayorova mayorova commented Oct 2, 2024

Update the Dockerfile for building a system image with Oracle dependencies, based on the system image from 3scale 2.15.

https://issues.redhat.com/browse/THREESCALE-11393

@mayorova mayorova changed the title Upgrade the Dockefile for system image based on RHEL8 THREESCALE-11393: Upgrade the Dockefile for system image based on RHEL8 Oct 3, 2024
Comment thread Dockerfile Outdated
Comment thread Dockerfile
ENV LD_LIBRARY_PATH=/opt/oracle/instantclient/:$LD_LIBRARY_PATH \
ENV LD_LIBRARY_PATH=/opt/oracle/instantclient/ \
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change this?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread Dockerfile
Comment on lines -16 to +19
RUN ./script/oracle/install-instantclient-packages.sh \
&& source /opt/app-root/etc/scl_enable \
&& DB=oracle bundle install --local --deployment --jobs $(grep -c processor /proc/cpuinfo) --retry=5
RUN dnf install wget unzip make ruby-devel gcc gcc-c++ redhat-rpm-config libaio -y \
&& ./script/oracle/install-instantclient-packages.sh \
&& ln -s /usr/lib64/libnsl.so.2 /usr/lib64/libnsl.so.1 \
&& DB=oracle bundle install --jobs $(grep -c processor /proc/cpuinfo) --retry=5
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is the ultimate fix. The root of the issue is that when building the system image, we now remove most build dependencies to have a slimmer image.

I don't know if we support disconnected environments. But installing these deps during build will not work in such.

So the above is a valid solution for internet connected builds. Although I'm concerned about the nsl linking.

An alternative solution would be to ship also a builder image that will be used for this kind of builds 🤔

Copy link
Copy Markdown

@akostadinov akostadinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are ok that image build requires internet connection to work, then it is a sound solution. Thank you.

@mayorova mayorova merged commit c33fc76 into main Nov 18, 2024
@mayorova mayorova deleted the upgrade-to-2.15 branch November 18, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants