This repository was archived by the owner on Jul 19, 2024. It is now read-only.
use Convert-ToDockerHostPath for docker tests#117
Merged
Conversation
viktor-kaydalov
requested review from
rasmusjelsgaard and
zionyx
as code owners
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
==========================================
+ Coverage 98.70% 98.76% +0.05%
==========================================
Files 25 26 +1
Lines 310 325 +15
==========================================
+ Hits 306 321 +15
Misses 4 4
|
lee-at-work
reviewed
Dec 4, 2020
Contributor
lee-at-work
left a comment
lee-at-work
left a comment
There was a problem hiding this comment.
Great work @viktor-kaydalov. A test covering those new codes will be nice.
Contributor
|
I am still struggling to create a working test for it. |
lee-at-work
approved these changes
Dec 16, 2020
Contributor
lee-at-work
left a comment
lee-at-work
left a comment
There was a problem hiding this comment.
Finally... Great work @viktor-kaydalov 🙌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Invoke-DockerTests is executed inside docker container (docker-in-docker scenario), use docker host path for volume mappings.
See also https://stackoverflow.com/questions/31381322/docker-in-docker-cannot-mount-volume