Skip to content
This repository was archived by the owner on Jul 19, 2024. It is now read-only.

DEKA-1255: Log errors before failing a pipeline#120

Merged
romankarnaukh merged 1 commit into
masterfrom
features/DEKA-1255
Sep 9, 2021
Merged

DEKA-1255: Log errors before failing a pipeline#120
romankarnaukh merged 1 commit into
masterfrom
features/DEKA-1255

Conversation

@romankarnaukh
Copy link
Copy Markdown
Contributor

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 6, 2021

Codecov Report

Merging #120 (c6b23a1) into master (11eb53d) will decrease coverage by 18.70%.
The diff coverage is 0.00%.

❗ Current head c6b23a1 differs from pull request most recent head e65a529. Consider uploading reports for the commit e65a529 to get more accurate results

@@             Coverage Diff             @@
##           master     #120       +/-   ##
===========================================
- Coverage   98.76%   80.06%   -18.71%     
===========================================
  Files          26       26               
  Lines         325      326        +1     
===========================================
- Hits          321      261       -60     
- Misses          4       65       +61     
Impacted Files Coverage Δ
Source/Public/Invoke-DockerTests.ps1 0.00% <0.00%> (-94.88%) ⬇️
Source/Private/Convert-ToUnixPath.ps1 0.00% <0.00%> (-100.00%) ⬇️
Source/Public/Invoke-DockerLint.ps1 12.00% <0.00%> (-88.00%) ⬇️

Comment thread Source/Private/Get-TestConfigs.ps1 Outdated
}
)

return $configsCmd
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would a result with more configs look like? Would it make sense to add an example so that it is easier to see what needs to be handled by the caller?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just moved the existing logic to a separate function because its used more than just one time, there are already some tests that covering this. And because this is a private function we dont expect someone will use it and if someone wants to use this inside this module they can refer to existing examples in Source/Public/Invoke-DockerTests.ps1.

@romankarnaukh romankarnaukh changed the title DEKA-1255: Support framework executable DEKA-1255: Log errors before failing a pipeline Sep 7, 2021
@romankarnaukh romankarnaukh merged commit 15e014d into master Sep 9, 2021
@romankarnaukh romankarnaukh deleted the features/DEKA-1255 branch September 9, 2021 07:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants