DEKA-1255: Log errors before failing a pipeline#120
Conversation
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
===========================================
- Coverage 98.76% 80.06% -18.71%
===========================================
Files 26 26
Lines 325 326 +1
===========================================
- Hits 321 261 -60
- Misses 4 65 +61
|
| } | ||
| ) | ||
|
|
||
| return $configsCmd |
There was a problem hiding this comment.
How would a result with more configs look like? Would it make sense to add an example so that it is easier to see what needs to be handled by the caller?
There was a problem hiding this comment.
I just moved the existing logic to a separate function because its used more than just one time, there are already some tests that covering this. And because this is a private function we dont expect someone will use it and if someone wants to use this inside this module they can refer to existing examples in Source/Public/Invoke-DockerTests.ps1.
96b136a to
92fd7dd
Compare
0f998a3 to
e65a529
Compare
No description provided.