Skip to content

feat!: Remove contents: read workflow permission #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chazypro merged 2 commits into from
Aug 31, 2024
+14 −12
Merged

feat!: Remove contents: read workflow permission #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
656d269
fix: Disable all github token scopes at workflow level
chris3ware Aug 30, 2024
5a91b4d
chore(pr-title): Add `${{ }}` syntax to conditionals
chris3ware Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/dependency-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,17 @@ on:
types: [opened, synchronize]
branches: [main]

permissions:
contents: read
# Disable permissions for all available scopes
permissions: {}

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref }}
cancel-in-progress: true

jobs:
dependency-review:
permissions:
contents: read
runs-on: ubuntu-latest
steps:
- name: Checkout Repository
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/get-terraform-dir.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,15 @@ on:
description: The terraform directory to initialise
value: ${{ jobs.terraform-directory.outputs.terraform-matrix }}

# Declare default permissions as read only.
permissions:
contents: read
# Disable permissions for all available scopes
permissions: {}

# TODO: Define single list of files to use in both steps
# See: https://github.com/3ware/workflows/issues/101
jobs:
terraform-directory:
permissions:
contents: read
runs-on: ubuntu-latest
timeout-minutes: 5
outputs:
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/pr-title.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Add PR comment on failure
if: always() && (steps.validate-pr-title.outputs.error_message != null)
if: ${{ always() && steps.validate-pr-title.outputs.error_message != null }}
uses: marocchino/sticky-pull-request-comment@331f8f5b4215f0445d3c07b4967662a32a2d3e31 # v2.9.0
with:
header: pr-title-error
Expand All @@ -41,20 +41,20 @@ jobs:
```

- name: Delete PR comment on resolution
if: always() && (steps.validate-pr-title.outputs.error_message == null)
if: ${{ always() && steps.validate-pr-title.outputs.error_message == null }}
uses: marocchino/sticky-pull-request-comment@331f8f5b4215f0445d3c07b4967662a32a2d3e31 # v2.9.0
with:
header: pr-title-error
delete: true

- name: Summary with valid title
if: always() && (steps.validate-pr-title.outputs.error_message == null)
if: ${{ always() && steps.validate-pr-title.outputs.error_message == null }}
run: |
echo "# :white_check_mark: Pull Request title is valid" >> $GITHUB_STEP_SUMMARY
echo "The pull request title conforms to the conventional commit specification."

- name: Summary without invalid title
if: always() && (steps.validate-pr-title.outputs.error_message != null)
if: ${{ always() && steps.validate-pr-title.outputs.error_message != null }}
run: |
echo "# :bangbang: Pull Request title is invalid" >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/terraform-docs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,8 @@ on:
type: string
required: true

# Declare default permissions as read only.
permissions:
contents: read
# Disable permissions for all available scopes
permissions: {}

jobs:
terraform-docs:
Expand Down