Feat/audit#12
Merged
Merged
Conversation
Bump @opentelemetry/*, @temporalio/*, drizzle-orm/kit, and turbo to current versions; pin vulnerable transitive deps (protobufjs, axios, ws, etc.) via root overrides. Require MPP_SECRET_KEY at startup instead of falling back to a hardcoded dev key.
Surfaced by knip and confirmed by hand: drop unused exports, the `findByWallet` repository helper, the `cctpToStellarAmount` shim, and the `@temporalio/testing` devDep that no test references. Trim direct dep declarations in worker/relay that were only reached transitively through `@402md/shared` so each package.json reflects real usage. Add a `knip.json` declaring Temporal-loaded workflows, the scripts/ utilities, and skill examples as entry points so future runs do not re-flag the same false positives.
The worker shipped vitest --passWithNoTests, leaving settlement workflows (the riskiest code) at zero coverage. The root-level test/e2e/same-chain-base.test.ts contained only it.skip placeholders not wired to any runner. EVM adapter helpers that gate EIP-3009 signature decomposition and CCTP messageHash identity were untested. Adds 23 tests across workflows (happy path with sellerAmount arithmetic, mint-failure compensation, transient retry, workflow idempotency) and EVM adapter helpers (splitSignature, padAddress, stellarAddressToBytes32, buildCctpForwarderHookData, extractMessageHash). Drops --passWithNoTests so an empty worker suite now reds the build. Removes the orphan e2e file.
Test file imports WorkflowExecutionAlreadyStartedError from @temporalio/client, which was only resolved transitively via @temporalio/testing — breaking tsc in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.