Use root .bowerrc as starting point, rather than creating one from scratch - #40
Merged
Conversation
Collaborator
|
Seems like we should create |
Author
|
You were right, I forgot that a .bowerrc is optional. Added a check if the file exists. Solution is a bit ugly since I have copied the |
Owner
|
looks like pull request #41 created some conflicts. Please resubmit pull. |
Author
|
@rharriso I merged the changes and rebased, should be good for a clean pull. |
Collaborator
|
Conflicts @ Changelog.md now. Rebase again, please. |
…ratch. Remove uneeded method.
SergeyKishenin
added a commit
that referenced
this pull request
Nov 12, 2013
Use root .bowerrc as starting point, rather than creating one from scratch
Collaborator
|
Thanks, merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case where a custom .bowerrc is needed, for example, with custom registries, it seemed that bower-rails was ignoring .bowerrc in the rails root directory, and generating a new .bowerrc per group. This loses any required settings. I didn't see any other way to set registries in bower-rails.
This PR reads the root .bowerrc, and merges in the "bower_components" directory to create the new generated .bowerrc files.