Skip to content

Find bower executable in local node_modules directory - #52

Merged
SergeyKishenin merged 3 commits into
rharriso:masterfrom
jimpo:local-node-modules
Dec 23, 2013
Merged

Find bower executable in local node_modules directory#52
SergeyKishenin merged 3 commits into
rharriso:masterfrom
jimpo:local-node-modules

Conversation

@jimpo

@jimpo jimpo commented Dec 17, 2013

Copy link
Copy Markdown
Contributor

Bower currently has to be installed somewhere on the PATH for the rake task to find it. If it is not, the error message is not very descriptive. This change searches for the bower executable (and looks in the local node_modules directory) before proceeding. If bower is not found, the rake task with print an error and exit.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same when pulling 24fc3c8 on jimpo:local-node-modules into e7829a4 on 42dev:master.

@SergeyKishenin

Copy link
Copy Markdown
Collaborator

Very cool, thanks. Could you also update readme and changelog?

@jimpo

jimpo commented Dec 21, 2013

Copy link
Copy Markdown
Contributor Author

For updating the Changelog, which release would this be in?

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same when pulling f8258ca on jimpo:local-node-modules into e7829a4 on 42dev:master.

@SergeyKishenin

Copy link
Copy Markdown
Collaborator

Edge is ok for now
On Dec 22, 2013 2:14 AM, "Jim Posen" notifications@github.com wrote:

For updating the Changelog, which release would this be in?


Reply to this email directly or view it on GitHubhttps://github.com//pull/52#issuecomment-31071281
.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same when pulling a15bc4f on jimpo:local-node-modules into e7829a4 on 42dev:master.

SergeyKishenin added a commit that referenced this pull request Dec 23, 2013
Find bower executable in local node_modules directory
@SergeyKishenin
SergeyKishenin merged commit f16669b into rharriso:master Dec 23, 2013
@SergeyKishenin

Copy link
Copy Markdown
Collaborator

Does this request mean that we can uncomment https://github.com/42dev/bower-rails/blob/master/lib/tasks/bower.rake#L53?

@jimpo

jimpo commented Dec 25, 2013

Copy link
Copy Markdown
Contributor Author

Nope, doesn't affect that. Haven't been able to get this working on Heroku
without committing components. I'll keep trying though.
On Dec 24, 2013 10:36 PM, "Sergey Kishenin" notifications@github.com
wrote:

Does this request mean that we can uncomment
https://github.com/42dev/bower-rails/blob/master/lib/tasks/bower.rake#L53?


Reply to this email directly or view it on GitHubhttps://github.com//pull/52#issuecomment-31190800
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants