Merged
Conversation
| log_debug ("Database is not ready yet."); | ||
| std::string err = TRANSLATE_ME ("Database is not ready yet, please try again after a while."); | ||
| if (request.getMethod () == "PUT") | ||
| log_info_audit ("Request PUT alert ack FAILED"); |
Contributor
There was a problem hiding this comment.
Just a comment. On failure treatment, we invoke log_info_audit(). It should be log_error_audit().
FrancoisRegisDegott-eaton
approved these changes
Jul 26, 2019
Member
|
Missed some headers? Otherwise LGTM ;) UPDATE: Missed at first the comment about dependency PRs |
jimklimov
approved these changes
Jul 30, 2019
jimklimov
approved these changes
Jul 30, 2019
jimklimov
reviewed
Jul 31, 2019
| audit_msg = std::string ("Request CREATE auth username ") + username + " FAILED"; | ||
| check_regex_text_or_die ("token", token, checked_token, "^[-/._~+/a-z0-9]{0,255}={0,10}$", | ||
| audit_msg = std::string ("Request CREATE auth FAILED"); | ||
| check_regex_text_or_die_audit ("token", token, checked_token, "^[-/._~+/a-z0-9]{0,255}={0,10}$", |
Member
There was a problem hiding this comment.
For future: macro names should be all same-style, commonly upper-cased.
Also, the CHECK_USER_PERMISSIONS_OR_DIE_AUDIT above casts (char *) nullptr while other cases I've seen recently do not...
jimklimov
approved these changes
Jul 31, 2019
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should provide necessary logs to get some idea about the auditing results.
This is dependant on 42ity/fty-common-rest#36 and won't pass until it is merged and updated on Jenkins/Travis