Conversation
Include the kernel-modules package in preconfiguration installs. Added kernel-modules to the ZFS/DKMS dependency list in rocky9-preconfig.sh and to the Cockpit package lists in rocky9-preconfig-ceph.sh and rocky9-preconfig-ceph-offline.sh to ensure kernel module support for DKMS/ZFS and related cockpit modules.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Rocky 9 preconfiguration scripts to ensure kernel-modules is installed as part of preconfig package installs, supporting scenarios that rely on kernel module availability (e.g., DKMS/ZFS and Cockpit-related modules).
Changes:
- Added
kernel-modulesto the ZFS/DKMS dependency install list inrocky9-preconfig.sh. - Added
kernel-modulesto Cockpit package install lists inrocky9-preconfig-ceph.shandrocky9-preconfig-ceph-offline.sh.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| rocky9-preconfig.sh | Adds kernel-modules to ZFS dependency installation (plus a small log-message accuracy nit). |
| rocky9-preconfig-ceph.sh | Adds kernel-modules to Cockpit install list for Ceph preconfig. |
| rocky9-preconfig-ceph-offline.sh | Adds kernel-modules to Cockpit install list for offline Ceph preconfig. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -151,7 +151,7 @@ install_zfs() { | |||
|
|
|||
| echo "Installing dependencies: dkms, kernel headers, ZFS, ZFS-dkms" | |||
bkelly16
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include the kernel-modules package in preconfiguration installs. Added kernel-modules to the ZFS/DKMS dependency list in rocky9-preconfig.sh and to the Cockpit package lists in rocky9-preconfig-ceph.sh and rocky9-preconfig-ceph-offline.sh to ensure kernel module support for DKMS/ZFS and related cockpit modules.