Conversation
We generate a random message, encode it in protobuf text format, use both pbdirect and protoc to encode it as protobuf binary, and compare the resulting bytes.
BenFradet
approved these changes
Dec 30, 2019
| * But then we'd be basically reinventing the whole | ||
| * library but for text instead of binary, and then using | ||
| * that to test the behaviour of the library. Feels a bit | ||
| * weird. |
Member
Author
|
Looks like this test is flaky on Travis, but works fine for me locally. So the build is broken on master now 😞 Looking at this log, it looks like protoc sometimes outputs nothing, which means the process probably failed to run. I'll investigate. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a property-based test to check that the bytes generated by pbdirect for a complex message are identical to the output of the
protoccommand-line tool.The test works as follows.
For a given randomly-generated message:
protocwants as its inputprotocto encode the message to protobuf bytes, passing it the text-format encoded message and a.protofile as inputprotocare identical