Skip to content

Fix flaky test#33

Merged
cb372 merged 8 commits intomasterfrom
fix-flaky-test
Dec 31, 2019
Merged

Fix flaky test#33
cb372 merged 8 commits intomasterfrom
fix-flaky-test

Conversation

@cb372
Copy link
Copy Markdown
Member

@cb372 cb372 commented Dec 31, 2019

This PR fixes the flakiness introduced by the new ProtocComparisonSpec added in #32.

  • Fix test flakiness on Scala 2.12. There was a timing issue because the output from protoc does not always arrive in the buffer before the process exits.
  • Disable the test on Scala 2.11. It kept hanging randomly and I can't figure out why.

Copy link
Copy Markdown

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -1,3 +1,5 @@


Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎨

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added by that damned license headers plugin that I can't figure out how to disable 🙃

@cb372 cb372 merged commit 8683d70 into master Dec 31, 2019
@cb372 cb372 deleted the fix-flaky-test branch December 31, 2019 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants