Fix decimal separator handling with fixedDecimalScale#17
Merged
Conversation
Patch release fixing the decimal jump UX bug — typing the decimal separator when one already exists now moves the cursor past it instead of inserting a duplicate that clears the field on blur. https://claude.ai/code/session_01JTrExiikywjtpc5NMCmMQf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where typing the decimal separator when
fixedDecimalScaleis enabled (e.g., displaying "1.00") would insert a duplicate separator, invalidating the value and clearing the field on blur.The fix ensures that when the decimal separator key is pressed and one already exists in the input, the cursor jumps to just after the existing decimal point instead of inserting a duplicate. This enables the standard financial input pattern: "1.00" → type "." → cursor moves after "." → type "5" → "1.50".
The behavior is locale-aware: only the locale's own decimal separator triggers the cursor jump (e.g., "," in de-DE), so the grouping separator is unaffected.
Checklist
pnpm testpasses locallypnpm typecheckpasses (0 errors)pnpm lintpasses (Biome)pnpm changeset) for any user-facing changesRelated issues
Closes #
https://claude.ai/code/session_01JTrExiikywjtpc5NMCmMQf