Merged
Conversation
BO converging on a box constraint emits near-duplicate floats (500.0 vs 500.0000000000001) that hash to different arm signatures and slip past Ax's should_deduplicate. Fix by picking a magnitude-aware default `digits` on float `Dimension.range`s and rounding in `coerce_value` before any value reaches Ax.
- `ask()` on an uninitialized backend now raises a clear RuntimeError instead of falling through to an Ax AssertionError. - `tell()` on an unevaluated case points the caller at batch_process instead of the deep "output None for case" message. - `sys.exit` on optimizer completion becomes `OptimizationComplete`, caught in Session on both local-ask and offload branches. - Drop the "Cannot proceed: no trials received (TODO fix)" raise; an empty get_next_trials is legitimate and already handled upstream.
Two slow end-to-end tests driving Session through pitzDaily in DockerLocal: a 12-cycle single-dim run with cold-reload round-trip, and a 2-dim parallel-batch run (4 cycles × 2 jobs) that reproduces the #18 boundary-convergence pattern end-to-end. ~80s combined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
digitson floatDimension.ranges and round incoerce_value, so BO-generated boundary near-duplicates (e.g.500.0vs500.0000000000001) collapse onto one arm and stop slipping past Ax's dedup — the actual root cause of Ax backend error: "Arm already exists with name … which doesn't match given arm name" when attaching trials #18.ask()on a fresh backend,tell()on an unevaluated case, andsys.exiton optimizer completion (now a catchableOptimizationComplete).Sessionthrough full tell/ask cycles — one single-dim persistence run, one 2-dim parallel-batch run that reproduces Ax backend error: "Arm already exists with name … which doesn't match given arm name" when attaching trials #18's pattern end-to-end.Tries to address findings in issue #18.