CI speed-ups, test coverage expansion, and correctness fixes#25
Merged
CI speed-ups, test coverage expansion, and correctness fixes#25
Conversation
- types.py: `if scalar_value:` → `if scalar_value is not None:` so 0/0.0 parse as numeric instead of falling through to string - dictionary.py: Entry.add delegates to self.dictionary.add instead of recursing into itself; fix return type annotation - session.py: persist/restore clone_method, max_evaluations, target_value, and target_objective so termination criteria survive a crash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A round of independent improvements that accumulated on this branch:
pytest_configure(not mid-test), and pytest-xdist runs cleanly in parallel.test_*_unit.py/test_*_extended.pyfor objectives, backend, search space, dictionary links, types, manager interfaces (Local/Slurm/Docker), session, config, and a deterministic-replay harness.Datarefactor: split into an ABC underflowboost/openfoam/data/with pluggable Pandas/Polars backends.Entry.addrecursion, session/manager persistence, case restore + foam parsing, dictionary/search-space edges, NaN/Inf rejection in objective outputs,offloaded_acquisitionerror message, type annotations across optimizer/manager/openfoam.A separate PR (
refactor/scalarized-objective) builds on top of this branch with a public-API change (AggregateObjective→ScalarizedObjective, drop of the flowboost-side normalization layer); reviewing this one first keeps the diffs focused.Test plan
uv run pytest -m "not slow"— full non-slow suite greenuv run ruff check— no new lint errors introduced by this branchtest_determinism.pyactually exercises the close/reopen replay path