Merged
Conversation
Stroid can now generate vacuume regions. These are confirming spheres marked with a seperate attribute that solver may then apply arbitrary mappings to. Further, the boundary of this region is also marked with a seperate boundary attrite allowing seperate boundary conditions to easily be applied.
Test suite has been updated to include a much more robust suite of tools for validating mesh quality and mesh usability (including but not limited to things such as validating that integrating over a sphere provides the correct volume, that the mesh is confirming, and that no elements are inverted)
This version brings proper support for external domains
A simple python helper script has been added to aid developers in visualizing the winding order of vertices
previously calling stroid -v would print the version but then continue on the default run case, now both -v and -d result in an immediate exit after their tasks are done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to solve for the gravitational potential of a non spherical body the correct boundary condition is that the potential is 0 at infinity. In order to solve this we need a mesh that extends past the stellar surface. Stroid can now generate such meshes. Note that stroid leaves it to solvers to implement a mapping that takes the finite distance surface of this "vacuum" zone and maps it to infinity (using something like a kelvin mapping).
This PR also brings an improved test suite and some new tooling for visualizing the winding order of the vertices used to generate the topology.