chore: Use pyvista/setup-headless-display-action for setup display#1367
Merged
chore: Use pyvista/setup-headless-display-action for setup display#1367
pyvista/setup-headless-display-action for setup display#1367Conversation
use `astral-sh/setup-uv` to setup uv instead of manual setup uv
Contributor
Reviewer's GuideThis PR updates several GitHub Actions workflows to standardize headless display setup using pyvista/setup-headless-display-action and simplifies test execution by running commands directly instead of via aganders3/headless-gui, while also switching to astral-sh/setup-uv for UV and Python environment setup in the prerelease tests workflow. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
📝 WalkthroughWalkthroughThree GitHub Actions workflows are updated to replace Windows-specific OpenGL setup and Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can get early access to new features in CodeRabbit.Enable the |
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1367 +/- ##
===========================================
- Coverage 93.13% 93.12% -0.02%
===========================================
Files 211 211
Lines 33272 33272
===========================================
- Hits 30988 30983 -5
- Misses 2284 2289 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/make_release.yml:
- Around line 38-43: The "Setup headless display" step using
pyvista/setup-headless-display-action (qt: true, wm: herbstluftwm) runs on
non-Linux matrix OSes and will fail; restrict that step to Linux by adding a
conditional (for example using if: runner.os == 'Linux' or if: matrix.os ==
'ubuntu-latest') to the step so the pyvista/setup-headless-display-action runs
only on Linux runners.
In @.github/workflows/test_prereleases.yml:
- Around line 65-69: The "Setup headless display" step using
pyvista/setup-headless-display-action with wm: herbstluftwm is Linux-specific
and must be skipped on non-Linux runners; update that step (the step named
"Setup headless display" that uses pyvista/setup-headless-display-action and
sets wm: herbstluftwm) to include a conditional guard (e.g., an if: that checks
runner.os == 'Linux' or matrix.os matches a Linux label) so the step only runs
on Linux matrix legs.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 8c9d5042-446f-410b-bf92-a56a7f8a8430
📒 Files selected for processing (3)
.github/workflows/make_release.yml.github/workflows/test_napari_repo.yml.github/workflows/test_prereleases.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use
astral-sh/setup-uvto setup uv instead of manual setup uvSummary by Sourcery
Update CI workflows to use a unified headless display setup and streamline Python/uv environment management for testing and releases.
CI:
Summary by CodeRabbit
Note: This release contains infrastructure and tooling improvements with no user-facing functionality changes.