Skip to content

Conversation

@kskaiser
Copy link

@kskaiser kskaiser commented Aug 21, 2025

References

Description

The read-only visibility mechanism for submission form fields was not working, as references to SectionVisibility attributes (main, other) remained after its removal in DSpace CRIS 2024.02.00.

Instructions for Reviewers

This fix adapts the relevant checks in field-parser.ts and adds the missing import required for correct handling of SubmissionVisibility.

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

The read-only visibility mechanism for submission form fields was not
working, as references to SectionVisibility attributes (`main`, `other`)
remained after its removal in DSpace CRIS 2024.02.00.

This fix adapts the relevant checks in `field-parser.ts` and adds the
missing import required for correct handling of `SubmissionVisibility`.

Signed-off-by: Katharina Kaiser <katharina.kaiser@tuwien.ac.at>
@4science-it 4science-it merged commit 3c96283 into 4Science:main-cris Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

broken read-only form field mechanism

2 participants