Fix error message when updating ORCID settings#23
Closed
enea4science wants to merge 4 commits into4Science:mainfrom
Closed
Fix error message when updating ORCID settings#23enea4science wants to merge 4 commits into4Science:mainfrom
enea4science wants to merge 4 commits into4Science:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a researcher tries to update their ORCID settings, an error message (“The update of the synchronization settings failed”) appears. Indeed REST call returned a 200 response code and settings are actually saved.
This PR fixes that by changing the response condition from
isSuccesstohasSucceededas the last one checks for 'success' and 'successStale'.Checklist
yarn run lintpackage.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.