ESS-2234-2: Improvements to fetching aggregate data#122
Merged
branislav-jenco-4ss merged 6 commits intomasterfrom Jan 19, 2024
Merged
ESS-2234-2: Improvements to fetching aggregate data#122branislav-jenco-4ss merged 6 commits intomasterfrom
branislav-jenco-4ss merged 6 commits intomasterfrom
Conversation
59a50fe to
e4e887d
Compare
bjorn-einar-bjartnes-4ss
previously approved these changes
Jan 18, 2024
Contributor
bjorn-einar-bjartnes-4ss
left a comment
There was a problem hiding this comment.
Excellent
Contributor
There was a problem hiding this comment.
minor comment - example of usage in documentation uses "Avg", while docstring now only lists the pandas syntax. Besides that - nice work!
another thought - should example be from 2024 or something so that at least right now its within the last 90 days?
Contributor
Author
Good points, fixed :) |
heidi-holm-4ss
approved these changes
Jan 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to user story ESS-2234
Description
A couple improvements to the work done on making a method to get aggregate data using the client.
paging.mp4
paging_jupyter.mp4
Checklist
PR title tips: