Make progress bar dependent on log level#124
Merged
hanne-opseth-rygg-4ss merged 5 commits intomasterfrom Apr 25, 2024
Merged
Conversation
hanne-opseth-rygg-4ss
changed the title
hanne-opseth-rygg-4ss
requested review from
bjorn-einar-bjartnes-4ss and
heidi-holm-4ss
bjorn-einar-bjartnes-4ss
approved these changes
Apr 25, 2024
heidi-holm-4ss
approved these changes
Apr 25, 2024
hanne-opseth-rygg-4ss
deleted the
ESS-2553-make-progress-indicator-optional-in-get-samples-aggregate-function
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to user story ESS-2553
Description
Based on feedback from user of the package we have set the progress bar to only be visible if the user of the package sets the log level to below WARNING. WARNING is the default log level for the package. The change also handles a future warning in pandas.
Checklist