Ensure sorted data on upload of data from python #126
Merged
hanne-opseth-rygg-4ss merged 4 commits intomasterfrom Jun 4, 2024
Conversation
hanne-opseth-rygg-4ss
requested review from
branislav-jenco-4ss and
heidi-holm-4ss
| series.index.name = None | ||
|
|
||
| if series.empty and raise_empty: # may become empty after slicing | ||
| raise ValueError("can't find data in the given interval") |
Contributor
Author
There was a problem hiding this comment.
Here you might get the warning that you've gotten a keyError and that we try to sort the data and then you will get another valueError saying that the program can't find data. Should i maybe copy the following code into each part of the try/except?
series.index.name = None
if series.empty and raise_empty: # may become empty after slicing
raise ValueError("can't find data in the given interval")
Contributor
branislav-jenco-4ss
left a comment
branislav-jenco-4ss
left a comment
There was a problem hiding this comment.
Just a couple nitpicks!
hanne-opseth-rygg-4ss
deleted the
ESS-2644-fetching-data-via-get-in-python-implicitly-expects-sorted-data-uploading-doesnt-validate-that-it-is
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to user story ESS-2644
Description
Not allowed to create and append to timeseries of the index is not sorted. If a KeyError is raised when trying to get data, the data is sorted before once more trying to access the specific date range.