Ess 2670 update drio python documentation to let the user know that cold path and adx has different time resolution#128
Merged
hanne-opseth-rygg-4ss merged 6 commits intomasterfrom Jun 5, 2024
Conversation
…to-let-the-user-know-that-cold-path-and-adx-has-different-time-resolution
hanne-opseth-rygg-4ss
requested review from
branislav-jenco-4ss and
heidi-holm-4ss
Contributor
Author
|
I will make sure when I release the package that the release notes will not become weird |
hanne-opseth-rygg-4ss
added
documentation
heidi-holm-4ss
previously approved these changes
Jun 5, 2024
Contributor
heidi-holm-4ss
left a comment
heidi-holm-4ss
left a comment
There was a problem hiding this comment.
please see small comment
|
|
||
| The time resolution of aggregated data is in milliseconds, while the time resolution of non-aggregated data is in nanoseconds. This may lead to discrepancies in data when comparing the two, and some datapoints might get lost when using aggregation to access data, in cases when there are multiple datapoints within the same nanosecond. | ||
|
|
||
| The time resolution of aggregated data is in 100 nanoseconds, while the time resolution of non-aggregated data is in nanoseconds. This may lead to discrepancies in data when comparing the two, and some datapoints might get lost when using aggregation to access data, in cases when there are multiple datapoints within the same 100 nanosecond range. |
Contributor
There was a problem hiding this comment.
maybe rephrase to "The time resolution of aggregated data is in ticks (1tick = 100 nanoseconds)..."
heidi-holm-4ss
approved these changes
Jun 5, 2024
hanne-opseth-rygg-4ss
deleted the
ESS-2670-update-drio-python-documentation-to-let-the-user-know-that-cold-path-and-adx-has-different-time-resolution
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to user story ESS-2670