Skip to content

[UPLUS-125] SMS 제목 null처리 삭제 #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arlen02-01 merged 3 commits into from
Jan 26, 2026
Merged

[UPLUS-125] SMS 제목 null처리 삭제 #40

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84489cb
[UPLUS-125] fix : 탬플릿 버전 sms는 제목 null처리 삭제
arlen02-01 Jan 26, 2026
e8d0903
[UPLUS-125] fix : 탬플릿 버전 sms는 제목 null처리 삭제
arlen02-01 Jan 26, 2026
2234534
[UPLUS-125] style : 스타일 적용
arlen02-01 Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions src/main/java/com/project/notification/service/TemplateVersionService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public TemplateVersionResponse createVersion(

int nextVersion = versionRepository.findMaxVersion(groupId, request.channel()) + 1;

String subject = normalizeSubject(request.channel(), request.subject());
String subject = request.subject();
TemplateVersion version =
TemplateVersion.builder()
.templateGroup(group)
Expand Down Expand Up @@ -139,7 +139,7 @@ public TemplateVersionResponse updateVersion(
validateBody(request.body());
}

String subject = normalizeSubject(version.getChannel(), request.subject());
String subject = request.subject();
Comment thread
arlen02-01 marked this conversation as resolved.
version.updateContent(subject, request.body(), request.variables());

return TemplateVersionResponse.from(version);
Expand Down Expand Up @@ -243,13 +243,6 @@ private void validateBody(String body) {
}
}

private String normalizeSubject(Channel channel, String subject) {
if (channel == Channel.SMS) {
return null;
}
return subject;
}

private Set<String> extractRequiredKeys(Map<String, Object> variables) {
if (variables == null) {
return Set.of();
Expand Down