fix(auth): doctor reads token from current profile#6
Merged
Conversation
After profile-based login, cfg.Token is empty because MigrateToProfiles clears it. doctor was only checking the legacy top-level token field, causing it to always report 'no token found' even after a successful login. Fixes 4ier#5
Owner
|
Clean fix, merged! Thanks for tracking down the profile format mismatch. 🎯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5
notion auth doctoralways failed with✗ Config: no token foundeven after a successfulnotion auth login, because it was checking the legacy top-levelcfg.Tokenfield — which is cleared byMigrateToProfiles()when the new profile format is used.Root Cause
auth loginstores the token incfg.Profiles["default"].Token, notcfg.Token. AfterMigrateToProfiles()runs, the top-levelTokenfield is cleared.Fix
Resolve the token via
GetCurrentProfile()(the existing accessor) when the legacy field is empty, then use that token for both the nil-check and the API client:Testing
Before:
notion auth login→notion auth doctor→✗ Config: no token foundAfter:
notion auth login→notion auth doctor→All checks passed ✓