Skip to content

feat: support parameterized query for python sdk#304

Merged
tobegit3hub merged 5 commits into
4paradigm:mainfrom
jingchen2222:feat/python_sdk_for_parameterized_query
Aug 30, 2021
Merged

feat: support parameterized query for python sdk#304
tobegit3hub merged 5 commits into
4paradigm:mainfrom
jingchen2222:feat/python_sdk_for_parameterized_query

Conversation

@jingchen2222
Copy link
Copy Markdown
Collaborator

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

feature

    # test parameterized query in batch mode case 3
    logging.info("[Execute]: select * from tsql1010 where col3 = ? and col1 < ?; ('province3', 1008)")
    rs = connection.execute("select * from tsql1010 where col3 = ? and col1 < ?;", ('province3', 1008))
    self.show(rs);
    expectRows = [
      (1006, '2020-12-31', 'province3', 'city7', 7),
      (1007, '2021-01-01', 'province3', 'city8', 8),
      ]
    self.check_result(rs, expectRows)
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

@jingchen2222 jingchen2222 added this to the v0.3 milestone Aug 26, 2021
@jingchen2222 jingchen2222 self-assigned this Aug 26, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 26, 2021

Linux Test Report

     49 files  ±0     122 suites  ±0   34m 5s ⏱️ ±0s
8 013 tests ±0  8 013 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
8 018 runs  ±0  8 018 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 31b14fb. ± Comparison against base commit 31b14fb.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 26, 2021

HybridSE Linux Test Report

       71 files  ±0       220 suites  ±0   4m 19s ⏱️ ±0s
18 041 tests ±0  18 041 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
18 048 runs  ±0  18 048 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 31b14fb. ± Comparison against base commit 31b14fb.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 26, 2021

HybridSE Mac Test Report

       71 files  ±0       220 suites  ±0   5m 29s ⏱️ ±0s
18 041 tests ±0  18 041 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
18 048 runs  ±0  18 048 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 31b14fb. ± Comparison against base commit 31b14fb.

♻️ This comment has been updated with latest results.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 27, 2021

Codecov Report

Merging #304 (8cf2da5) into main (cf165d3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #304   +/-   ##
=========================================
  Coverage     81.90%   81.90%           
  Complexity       13       13           
=========================================
  Files           283      283           
  Lines         50545    50545           
  Branches         29       29           
=========================================
  Hits          41399    41399           
  Misses         9137     9137           
  Partials          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf165d3...8cf2da5. Read the comment docs.

Copy link
Copy Markdown
Collaborator

@aceforeverd aceforeverd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobegit3hub tobegit3hub merged commit 31b14fb into 4paradigm:main Aug 30, 2021
@jingchen2222 jingchen2222 linked an issue Aug 30, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support parameterized query in Python SDK

4 participants