feat: add parse method genOutputSchema and make parse methods static #703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
| logger.error("executeSQL fail: {}", status.getMsg()); | ||
| } | ||
| status.delete(); | ||
| status = null; |
Collaborator
There was a problem hiding this comment.
@dl239 Why didi we use status = null after status.delete()? Did you try to deal with memory leaking?
Collaborator
There was a problem hiding this comment.
I have not tested whether it has impact on memory release if it is not set to null. In theory, it does not need to be set to null because status.delete() can release the memory alloced in C++.
java/openmldb-jdbc/src/test/java/com/_4paradigm/openmldb/jdbc/SQLRouterSmokeTest.java
Show resolved
Hide resolved
dl239
reviewed
Nov 17, 2021
java/openmldb-jdbc/src/main/java/com/_4paradigm/openmldb/sdk/impl/SqlClusterExecutor.java
Show resolved
Hide resolved
dl239
reviewed
Nov 17, 2021
java/openmldb-jdbc/src/main/java/com/_4paradigm/openmldb/sdk/impl/SqlClusterExecutor.java
Show resolved
Hide resolved
dl239
approved these changes
Nov 17, 2021
aceforeverd
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #689