Skip to content

Harden LexWork signer API migration#3

Merged
Joel-Luca merged 1 commit into
masterfrom
update-sitrox-signer-api
Apr 23, 2026
Merged

Harden LexWork signer API migration#3
Joel-Luca merged 1 commit into
masterfrom
update-sitrox-signer-api

Conversation

@all4manu
Copy link
Copy Markdown
Member

@all4manu all4manu commented Apr 21, 2026

Summary

  • add the JSON Accept header required by the new Sitrox signer API
  • cover the new signer endpoints and JSON request body with unittest coverage
  • fix README usage for the exported client and sign_pdf arguments

Tests

  • python -m unittest discover -s tests
  • python -m compileall lexwork tests
  • git diff --check

Note: black/isort/flake8 were not available in the local environment; CI runs them after poetry install.

Related PBI TI-3780

@all4manu all4manu marked this pull request as ready for review April 21, 2026 11:23
@all4manu all4manu requested a review from Joel-Luca April 21, 2026 11:23
Copy link
Copy Markdown
Member

@Joel-Luca Joel-Luca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Joel-Luca Joel-Luca merged commit da50f80 into master Apr 23, 2026
1 check passed
@Joel-Luca Joel-Luca deleted the update-sitrox-signer-api branch April 23, 2026 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants