Skip to content

Conversation

@ViaoV
Copy link
Contributor

@ViaoV ViaoV commented Jul 19, 2018

Routes have been moved into an interface and routes can now be any structure that implements it. This was done to better support different types of routing. BasicRoute holds all previous functionality, but two other route structures were added LocalFileRoute and LocalPathRoute to better handle file serving. This lets those routes implement their own matching logic to allow passing through when the local file doesn't exist.

This also allows scope collision to work correctly with served paths.

Resolves #48

@coveralls
Copy link

coveralls commented Jul 19, 2018

Pull Request Test Coverage Report for Build 157

  • 59 of 59 (100.0%) changed or added relevant lines in 4 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 82.797%

Files with Coverage Reduction New Missed Lines %
server.go 5 68.48%
Totals Coverage Status
Change from base Build 143: 0.4%
Covered Lines: 592
Relevant Lines: 715

💛 - Coveralls

@ViaoV ViaoV merged commit a4adaa6 into master Jul 20, 2018
@ViaoV ViaoV deleted the route-types branch July 20, 2018 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants