Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Duplicate deeplinked rejection possible #3058

@iamacook

Description

@iamacook

Description

When rejecting a deeplinked transaction as a singular owner, you complete the rejection transaction immediately and are then navigated to the on-chain rejection overview. However, on the on-chain rejection, it then asks for confirmation again, which has effectively already occured. By waiting for the next transaction list poll, the app will re-render and show that it has been indeed been executed.

We need to disable the execute/confirm possibility for single owners on on-chain rejection transactions that have already occured.

Note: The { type: 'Custom', isCancellation: true, ...txDetails } flags do not seem to be initially be accessible, perhaps because of the indexing speed (cc @jpalvarezl)?

Steps to reproduce

  1. Queue a transaction on a Safe with one owner.
  2. Reject the transaction and get create/get navigated to the on-chain rejection transaction.
  3. Confirm button is visible and clickable

Expected result

Confirm button is not displayed and transaction shown as confirmed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Bug 🐛Something isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions