This repository was archived by the owner on Nov 10, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 360
Replace Loader by component from SRC #2119
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
fernandomg
approved these changes
Apr 1, 2021
dasanra
approved these changes
Apr 5, 2021
nicosampler
approved these changes
Apr 5, 2021
Contributor
Contributor
|
The rest of the loaders looks fine. |
Contributor
|
Safe and env: The loaders reported were fixed. They are shown in green just fine I don't have the issue of the scroll bar wiggling anymore (ticket #2140). I recreated the same scenario where I reported the issue and it doesn't happen anymore. |
francovenica
approved these changes
Apr 13, 2021
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Member
|
Awesome! 👏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2100 and #2140
Now we use the Loader component from SRC
https://components.gnosis-safe.io/?path=/docs/feedback-loader--loader