Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Conversation

@alongoni
Copy link
Contributor

@alongoni alongoni commented Apr 1, 2021

Closes #2100 and #2140
Now we use the Loader component from SRC
https://components.gnosis-safe.io/?path=/docs/feedback-loader--loader

@alongoni alongoni requested a review from nicosampler April 1, 2021 19:27
@github-actions
Copy link

github-actions bot commented Apr 1, 2021

CLA Assistant Lite All Contributors have signed the CLA.

@alongoni alongoni self-assigned this Apr 1, 2021
@alongoni alongoni added the Tech-debt 🚧 Technical debt label Apr 1, 2021
@alongoni alongoni requested a review from fernandomg April 1, 2021 19:31
@github-actions
Copy link

github-actions bot commented Apr 1, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

github-actions bot commented Apr 1, 2021

@github-actions
Copy link

github-actions bot commented Apr 1, 2021

@francovenica
Copy link
Contributor

francovenica commented Apr 5, 2021

I think this icon is black instead of green, is too fast for me to confirm if it is the same component with different color or a different component all together. This icon shows up when you open "New transaction" and then pick one of the 3 options. (is the loading of the form)

image.png

Edit:
It seems to be the correct component, but is black instead of green for some reason
image.png

@francovenica
Copy link
Contributor

The rest of the loaders looks fine.

@dasanra dasanra requested a review from francovenica April 12, 2021 16:17
@francovenica
Copy link
Contributor

Safe and env:
https://pr2119--safereact.review.gnosisdev.com/rinkeby/app/#/safes/0x9913B9180C20C6b0F21B6480c84422F6ebc4B808/transactions

The loaders reported were fixed. They are shown in green just fine

I don't have the issue of the scroll bar wiggling anymore (ticket #2140). I recreated the same scenario where I reported the issue and it doesn't happen anymore.
04-13-2021_x(2266).gif

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@dasanra dasanra merged commit 3a117c5 into development Apr 14, 2021
@dasanra dasanra deleted the bugfix/#2100-Loader-component-from-SRC branch April 14, 2021 07:02
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2021
@katspaugh
Copy link
Member

Awesome! 👏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Tech-debt 🚧 Technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Loader: Make use of the one from SRC.

7 participants