Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Set v1.3.0 as default version#2608

Merged
dasanra merged 5 commits intodevfrom
feature/upgrade-to-v1.3.0
Aug 9, 2021
Merged

Set v1.3.0 as default version#2608
dasanra merged 5 commits intodevfrom
feature/upgrade-to-v1.3.0

Conversation

@dasanra
Copy link
Copy Markdown
Collaborator

@dasanra dasanra commented Aug 4, 2021

What it solves

Resolves #2572 and #2550

How this PR fixes it

Set v1.3.0 as latest version for all networks. This opens the possibility to execute an upgrade from previous version through the interface.

It also assign v1.0.0 as contract interface for safes using a version before 1.0.0 to add a minimum compatibility. It will allow to load and upgrade v0.1.0 safes

How to test it

Try to upgrade safes from v1.0.0 onward.
Check normal operation with v1.3.0 safes (shouldn't be surprises because it's already working on BSC and Polygon)
Loading safes using a version older than 1.0.0 should work as expected

Upgrading from v0.1.0 could be possible, although is not required.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 4, 2021

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 4, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 3 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 4, 2021

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 4, 2021

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 4, 2021

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 4, 2021

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 4, 2021

E2E Tests Passed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1098236147

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 4, 2021

E2E Tests Passed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1098320399

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 4, 2021

E2E Tests Passed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1098352829

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 5, 2021

E2E Tests Passed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1101065261

@dasanra dasanra self-assigned this Aug 6, 2021
@dasanra dasanra marked this pull request as ready for review August 6, 2021 07:24
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 6, 2021

E2E Tests Passed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1104268960

@dasanra dasanra requested review from katspaugh and mmv08 August 6, 2021 08:58
Copy link
Copy Markdown
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@francovenica
Copy link
Copy Markdown
Contributor

Created a safe 1.3.0 in rinkeby just fine
0x7e754b7FE711c5443bC82334bD4B62ce8B02FEad

Updated a 1.1.1 and a 1.0.0 safes to 1.3.0 just fine in rinkeby:
0xAC9A9Ce96f8603e86956b002e5d99138685e1dF2
0xE554dd1EdFbd8AF5bfADd2230B90f7b9Be871c8E

Tried a few tx in safes 1.1.1 and 1.3.0 and I didn't had any issues

@dasanra dasanra merged commit 5cb928e into dev Aug 9, 2021
@dasanra dasanra deleted the feature/upgrade-to-v1.3.0 branch August 9, 2021 14:30
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1.3.0 support on mainnet

4 participants