Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Hotfix v3.12.1#2647

Merged
dasanra merged 2 commits intomainfrom
hotfix/v3.12.1
Aug 17, 2021
Merged

Hotfix v3.12.1#2647
dasanra merged 2 commits intomainfrom
hotfix/v3.12.1

Conversation

@dasanra
Copy link
Copy Markdown
Collaborator

@dasanra dasanra commented Aug 16, 2021

What it solves

Resolves #
Issue with xDai, EWC and Volta that used L1 smart contracts while they are L2 networks and should be using those.

How this PR fixes it

Check to use L1 or L2 instance is not taking into account that before version v1.3.0 there wasn't a L2 instance of the Safe smart contract. Just add a check to allow use L2 smart contract when we try to use on a L2 network and smart contract is >=1.3.0

@dasanra dasanra requested a review from katspaugh August 16, 2021 14:10
@github-actions
Copy link
Copy Markdown

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link
Copy Markdown

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 1 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1135784754

Copy link
Copy Markdown
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@liliya-soroka
Copy link
Copy Markdown
Member

liliya-soroka commented Aug 17, 2021

Checked:
xDai:

  • safe creation with 1.3.0L2 mastercopy
  • safe update( from 1.1.1 to 1.3.0)
  • tx execution in the safe with 1.1.1 mastercopy ( 1 of N) (M of N)
  • tx execution in the safe with 1.3.0L2 mastercopy ( 1 of N) (M of N)

EWC:

  • safe creation with 1.3.0L2 mastercopy
  • safe update( from 1.1.1 to 1.3.0)
  • tx execution in the safe with 1.1.1 mastercopy ( 1 of N) (M of N)
  • tx execution in the safe with 1.3.0L2 mastercopy ( 1 of N) (M of N)

Rinkeby:

  • safe creation with 1.3.0L2 mastercopy
  • safe update( from 1.1.1 to 1.3.0)
  • tx execution in the safe with 1.1.1 mastercopy ( 1 of N) (M of N)
  • tx execution in the safe with 1.3.0L2 mastercopy ( 1 of N) (M of N)

@katspaugh and @dasanra Verified, mastercopy related staff work on xDai and EWC, nothing changed for Rinkeby

@dasanra dasanra merged commit 6223224 into main Aug 17, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants