This repository was archived by the owner on Nov 10, 2023. It is now read-only.
Conversation
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
|
E2E Tests Failed |
Member
|
Checked:
EWC:
Rinkeby:
@katspaugh and @dasanra Verified, mastercopy related staff work on xDai and EWC, nothing changed for Rinkeby |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #
Issue with xDai, EWC and Volta that used L1 smart contracts while they are L2 networks and should be using those.
How this PR fixes it
Check to use L1 or L2 instance is not taking into account that before version v1.3.0 there wasn't a L2 instance of the Safe smart contract. Just add a check to allow use L2 smart contract when we try to use on a L2 network and smart contract is >=1.3.0