Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Removed act warnings in the unit tests console#2700

Merged
DaniSomoza merged 4 commits intodevfrom
act-console-warning-tests
Sep 7, 2021
Merged

Removed act warnings in the unit tests console#2700
DaniSomoza merged 4 commits intodevfrom
act-console-warning-tests

Conversation

@DaniSomoza
Copy link
Copy Markdown
Contributor

What it solves

Removed act warnings in the unit tests console

How this PR fixes it

How to test it

Screenshots

@DaniSomoza DaniSomoza added the WIP label Sep 2, 2021
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 2, 2021

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 2, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 1 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 2, 2021

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 2, 2021

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 2, 2021

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 2, 2021

E2E Tests Passed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1195120722

@DaniSomoza DaniSomoza removed the WIP label Sep 3, 2021
@DaniSomoza DaniSomoza marked this pull request as ready for review September 3, 2021 09:58
@katspaugh katspaugh requested a review from iamacook September 3, 2021 10:34
Comment thread src/routes/load/Load.test.tsx
Comment thread src/routes/load/Load.test.tsx
Comment thread src/routes/load/Load.test.tsx
Comment thread src/routes/load/Load.test.tsx
@iamacook
Copy link
Copy Markdown
Contributor

iamacook commented Sep 3, 2021

Love the test! I have a few other suggestions but can't seem to comment on some areas of Load.test.tsx:

  • networkId, customState, validSafeAddress and validSafeENSNameDomain seem to be the same in all tests so I would move them outside so as to not repeat yourself.
  • Lines 126, 164, 208 should be inside act.
  • waitFor on line 128 could possibly be act if you are not waiting on something to load.
  • Depending on if the mocked function needs to be called legitimately elsewhere, you could move the mocks on lines 156 and 190 out of the tests into beforeEach. You can then clear them afterEach instead of repeating yourself on lines 166 and 215.

@DaniSomoza DaniSomoza merged commit c5730eb into dev Sep 7, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 7, 2021
@dasanra dasanra deleted the act-console-warning-tests branch October 20, 2021 15:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants