Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Add a warning in the Safe upgrade modal#2788

Merged
katspaugh merged 2 commits intodevfrom
upgrade-warning
Oct 4, 2021
Merged

Add a warning in the Safe upgrade modal#2788
katspaugh merged 2 commits intodevfrom
upgrade-warning

Conversation

@katspaugh
Copy link
Copy Markdown
Member

What it solves

Resolves #2787

How this PR fixes it

Adds a piece of text in the upgrade popup

How to test it

  • Go to settings
  • Click on upgrade safe

Screenshots

Screenshot 2021-10-04 at 11 06 49

@katspaugh katspaugh requested a review from mmv08 October 4, 2021 09:09
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 4, 2021

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 4, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 4, 2021

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 4, 2021

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 4, 2021

to confirm the update in case more than one confirmation is required for this Safe.
</Paragraph>

{/* A warning for 1.1.1 -> 1.3.0 upgrades */}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: it applies to all upgrades to 1.3.0 (1.0.0 too)

@katspaugh katspaugh merged commit 01d83b1 into dev Oct 4, 2021
@katspaugh katspaugh deleted the upgrade-warning branch October 4, 2021 09:31
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show a warning before a 1.3.0 Safe upgrade

2 participants