Fix: xDai – gas estimation; use EIP-1559; update RPC #3018
Conversation
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Pull Request Test Coverage Report for Build 1490750016
💛 - Coveralls |
Deployment links
|
|
E2E Tests Passed ✅ |
| rpcServiceUrl: 'https://dai.poa.network/', | ||
| safeAppsRpcServiceUrl: 'https://dai.poa.network/', | ||
| rpcServiceUrl: 'https://rpc.xdaichain.com/oe-only/', | ||
| safeAppsRpcServiceUrl: 'https://rpc.xdaichain.com/oe-only/', |
There was a problem hiding this comment.
Updated the RPC URLs to the ones used by the config-service.
src/config/chain-workarounds.ts
Outdated
| // How much to add to gasLimit per network | ||
| // Defaults to 1 (i.e. no extra gas) | ||
| export const EXTRA_GAS_FACTOR = { | ||
| [ETHEREUM_NETWORK.ARBITRUM]: 1.2, // +20% |
There was a problem hiding this comment.
This was added because of NFTs on Arbitrum. They can be now sent w/o a problem with no extra gas.
katspaugh
changed the title
src/logic/wallets/getWeb3.ts
Outdated
| export const getSDKWeb3ReadOnly = (signerAddress: string): Web3Adapter => { | ||
| return new Web3Adapter({ | ||
| web3: getWeb3ReadOnly(), | ||
| signerAddress, |
There was a problem hiding this comment.
is signerAddress a required property? because the read only instance obv can't sign anything
There was a problem hiding this comment.
Let me test if I can remove it.
There was a problem hiding this comment.
It's a required param, but it happily works with a zero address, so I'll use that.
katspaugh
force-pushed
the
fix-xdai-gas
branch
from
532011a to
7976f21
Compare
What it solves
Resolves #2999
How this PR fixes it
Adds 70% on top of estimated gas limit.
I've also updated the RPC URL to the one we use in the config-service.
And enabled EIP-1559
maxFeePerGasfor xDai.How to test it