Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Conversation

@katspaugh
Copy link
Member

@katspaugh katspaugh commented Nov 23, 2021

It's easier to maintain one single dependency than several small packages.

Fix debounced func type
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Nov 23, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 2 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

delay = 0,
options?: DebounceOptions,
): T & { cancel: () => void } => useCallback(debounce(callback, delay, options), [callback, delay, options])
): DebouncedFunc<T> => useCallback(debounce(callback, delay, options), [callback, delay, options])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@DiogoSoaress DiogoSoaress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@coveralls
Copy link

coveralls commented Nov 23, 2021

Pull Request Test Coverage Report for Build 1494033681

  • 1 of 3 (33.33%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 31.822%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/logic/hooks/useDebounce.tsx 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/logic/hooks/useDebounce.tsx 1 7.14%
Totals Coverage Status
Change from base Build 1491436673: -0.003%
Covered Lines: 2978
Relevant Lines: 8349

💛 - Coveralls

@iamacook
Copy link
Contributor

Don't miss the lint before merging

@github-actions
Copy link

Deployment links

🟠 Safe Rinkeby Safe Mainnet 🟣 Safe Polygon 🟡 Safe BSC Safe Arbitrum 🟢 Safe xDai

@katspaugh katspaugh merged commit 818f893 into dev Nov 23, 2021
@katspaugh katspaugh deleted the lodash branch November 23, 2021 09:25
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants