fix: only show safe sidebar on open Safes

[iamacook]

What it solves

Resolves #3458

How this PR fixes it

The Safe-specific sidebar is only shown when a Safe address exists in the URL. (The 'loaded' Safe remains in the store so it is necessary to use the URL as a flag as well).

How to test it

1. Open a Safe.
2. Click the Safe logo.
3. Observe that the Safe-specific sidebar is no longer visible.

Screenshots

[github-actions]

CLA Assistant Lite All Contributors have signed the CLA.

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

• Result: ✅ success
• Annotations: 0 total

---

^{Report generated by eslint-plus-action}

[github-actions]

Deployment links

🟠 Rinkeby	⚪ Mainnet	🟣 Polygon	🟡 BSC	⚫ Arbitrum	🟢 Gnosis Chain

[coveralls]

Pull Request Test Coverage Report for Build 1813497675

• 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.008%) to 33.495%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/components/AppLayout/Sidebar/SafeHeader/index.tsx	0	2	0.0%

Files with Coverage Reduction	New Missed Lines	%
src/components/AppLayout/Sidebar/SafeHeader/index.tsx	1	0%

Totals
Change from base Build 1813118881:	-0.008%
Covered Lines:	3211
Relevant Lines:	8551

---

💛 - Coveralls

[github-actions]

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1813531328

Failed tests:

• ❌ Read-only transaction creation and review Read-only transaction creation and review

[usame-algan]

Nice fix!

[katspaugh]

AFAIU the problem in the bug report isn't that the sidebar is open. It's the fact that the Safe address is displayed in it, although it failed to load.

[iamacook]

AFAIU the problem in the bug report isn't that the sidebar is open. It's the fact that the Safe address is displayed in it, although it failed to load.

The sidebar still shows Safe-related information when you navigate away from the Safe 'view':

Clicking on the gnosis logo on the top left takes you to the welcome page, but the info of the safe you are currently in still shows

We were previously retrieving the Safe address from the URL, but now that it checks the store, it is ever present. It would previously not show Safe-related information in the sidebar

[francovenica]

Looks good to me