Update dependencies, octanify moar things#45
Merged
Conversation
added 2 commits
February 11, 2020 14:39
fixes template lint error
added 3 commits
February 11, 2020 16:14
Fixes linter error and missing variables in template
Fixes linter errors
This is not ideal, but I don't see how to make the entire div interactive, while not violating nested-interactive rules either (when setting a `role="button"` on the div).
galfert
previously requested changes
Feb 12, 2020
Member
galfert
left a comment
galfert
left a comment
There was a problem hiding this comment.
The code looks all good to me. Just left a suggestion about the template linting rule.
But the styling of the revoke button is broken for me in both Chrome and Firefox:
added 2 commits
February 15, 2020 10:30
This reverts commit 7ed3fd1. The template directive doesn't work, but throws another linting error in itself.
Member
Author
I have a different PR for the small-screen UI coming in, which changes all of the app authorization layout. |
raucao
dismissed
galfert’s stale review
Comments resolved, layout solved in different PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I couldn't find a better way for toggling the auth div without violating the
invalid-interactiverule. See last commit.