refactor(race/subrace)!: remove redundant data #875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagelbits
approved these changes
Jul 9, 2025
bagelbits
changed the title
5e-bits-semantic-release-bot bot
pushed a commit
that referenced
this pull request
Sep 4, 2025
# [4.0.0](v3.26.1...v4.0.0) (2025-09-04) * refactor(race/subrace)!: remove redundant data ([#875](#875)) ([67261fb](67261fb)), closes [#874](#874) ### BREAKING CHANGES * dropped the `race.starting_proficiencies`, `race.starting_proficiency_options`, `subrace.starting_proficiencies`, `subrace.language_options`, and `subrace.languages` properties of all races and subraces in the database. Clients can instead find this data on the corresponding traits linked to each race or subrace. ## How was it tested? I ran the database + API project locally with Docker and called the endpoints of the various classes and subclasses. I also ran the unit and integration tests in the API project. ## Is there a Github issue this is resolving?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
BREAKING CHANGE: dropped the
race.starting_proficiencies,race.starting_proficiency_options,subrace.starting_proficiencies,subrace.language_options, andsubrace.languagesproperties of all races and subraces in the database. Clients can instead find this data on the corresponding traits linked to each race or subrace.How was it tested?
I ran the database + API project locally with Docker and called the endpoints of the various classes and subclasses. I also ran the unit and integration tests in the API project.
Is there a Github issue this is resolving?
Fixes #874
Did you update the docs in the API? Please link an associated PR if applicable.
I touched every reference of the properties in the API project. I took a look at the docs project, but couldn't fully find my way around the project to give a clear indication on if anything needed to change.
PR in API project
Here's a fun image for your troubles
One of my players designed their character after Clash of Clans P.E.K.K.A., and he dressed him up for the holidays last Christmas!
