Fail rumdl when warnings occur

[5ouma]

Don't ignore any warnings as well as errors.

[Copilot]

Pull request overview

This PR enhances the rumdl markdown linter configuration to treat warnings as failures, making the pre-commit hook stricter by not allowing any warnings to pass through unchecked.

• Adds --fail-on warning flag to the rumdl pre-commit hook configuration

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

Walkthrough

The rumdl hook configuration in the pre-commit setup has been updated to add a fail-on policy with the warning level, alongside the existing disable flags. This modifies the linting behavior to treat warnings as failures while maintaining the same MD code disables.

Changes

Cohort / File(s)	Summary
Pre-commit configuration \.pre-commit-config.yaml``	Added --fail-on warning flag to rumdl hook args while preserving existing --disable configuration with MD codes (MD013, MD024, MD033, MD036). Changes error handling behavior to elevate warnings to failures.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Fail rumdl when warnings occur' accurately summarizes the main change: adding --fail-on warning to the rumdl configuration to treat warnings as failures.
Description check	✅ Passed	The description 'Don't ignore any warnings as well as errors' is directly related to the changeset, which adds --fail-on warning to prevent ignoring warnings in rumdl linting.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch chore-pre-commit-rumdl-fail

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a2f279a and 5a14e4f.

📒 Files selected for processing (1)

• .pre-commit-config.yaml

🔇 Additional comments (1)

.pre-commit-config.yaml (1)

86-86: Change is correct and aligns with PR objectives.

The addition of --fail-on warning is properly implemented. The --fail-on flag is supported in rumdl v0.0.207 (added in v0.0.201), and warning is a valid option that causes rumdl to exit non-zero when warnings or errors occur. The YAML list syntax correctly passes --fail-on and warning as separate arguments. The existing --disable and --fix flags are properly maintained.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}